Bump oj from 2.1.2 to 3.6.10

[dependabot-preview]

Bumps oj from 2.1.2 to 3.6.10.

Changelog

Sourced from oj's changelog.

3.6.10 - 2018-09-13

• additional occurances of SYM2ID(sym) replaced.

3.6.9 - 2018-09-12

• SYM2ID(sym) causes a memory leak. A work around is now used.

3.6.8 - 2018-09-08

• Stopped setting the default options when optimze rails is called as the documentaiton has indicated.

• In custom mode Date and DateTime instances default to use the :time_format option is the :create_additions option is false.

3.6.7 - 2018-08-26

• Fixed incorrect check in StreamWriter when adding raw JSON.

3.6.6 - 2018-08-16

• Fixed Debian build issues on several platforms.

• oj_slash_string is now frozen.

3.6.5 - 2018-07-26

• Fixed GC issue with Oj::Doc.

• Fixed issue with time encoding with Windows.

3.6.4 - 2018-07-10

• JSON.generate() now sets the to_json option as expected.

• Show :create_additions in the default options. It did not appear before.

3.6.3 - 2018-06-21

• Fixed compat dump compilation error on Windows.

3.6.2 - 2018-05-30

• Regex encoded correctly for rails when using to_json.

• ActiveSupport::TimeWithZone optimization fixed.

3.6.1 - 2018-05-16

• Fixed realloc bug in rails dump.

... (truncated)

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge
• @dependabot reopen will reopen this PR if it is closed
• @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

[greysteil]

The test failure on this looks random - I'm pretty confident that this update is non-breaking.

[mkllnk]

Yes, that spec is known to be unreliable. I triggered a rebuild and Kristina will look at fixing the spec.

[mkllnk]

This looks reasonable and shouldn't need much testing. Just a sanity check.

But I'm actually wondering about the use of oj. It is a JSON processor that's faster than Rails' to_json method (six times faster). But do we need to call it explicitly (which we don't)? Or does the presence of the gem automagically replace Rails' to_json? I ran the specs without oj and they take the same time. But that may just be, because we have very little data in testing.

@greysteil Do you know if this gem benefits us at all?

[greysteil]

Just the presence of the gem should be enough to automagically replace Rails' to_json method. It might be that serialising JSON doesn't take much of the time in a test run (which is normally more affected by database calls), which would explain the lack of affect in testing.

Your call on whether to keep of scrap. It almost certainly isn't hurting performance, but perhaps the uncertainty / complexity means it's not worth having.

[luisramos0]

I vote keep :-)

[sauloperez]

Yep, not an issue. Let's keep it.

[luisramos0]

staged here https://staging.openfoodfrance.org

[RachL]

@luisramos0 I did a sanity check and everything looks good. Excep I did not received any emails. Is this an issue on the server ?
Testing notes : https://docs.google.com/document/d/14xYZYL8ut_YIrQEveii_U4Bz1vtMSFrBvTAQ4XqBaWc/edit#

[RachL]

@luisramos0 scrap that, I've tested with another email it works ;) Just a bit slow

[luisramos0]

👍