Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oj from 2.1.2 to 3.6.7 #2621

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps oj from 2.1.2 to 3.6.7.

Changelog

Sourced from oj's changelog.

3.6.7 - 2018-08-26

  • Fixed incorrect check in StreamWriter when adding raw JSON.

3.6.6 - 2018-08-16

  • Fixed Debian build issues on several platforms.

  • oj_slash_string is now frozen.

3.6.5 - 2018-07-26

  • Fixed GC issue with Oj::Doc.

  • Fixed issue with time encoding with Windows.

3.6.4 - 2018-07-10

  • JSON.generate() now sets the to_json option as expected.

  • Show :create_additions in the default options. It did not appear before.

3.6.3 - 2018-06-21

  • Fixed compat dump compilation error on Windows.

3.6.2 - 2018-05-30

  • Regex encoded correctly for rails when using to_json.

  • ActiveSupport::TimeWithZone optimization fixed.

3.6.1 - 2018-05-16

  • Fixed realloc bug in rails dump.

3.6.0 - 2018-05-01

  • Add optimization for Rails ActiveRecord::Result encoding.

3.5.1 - 2018-04-14

  • Fixed issue with \u0000 terminating keys early.

  • Add trace for calls to to_json and 'as_json`.

3.5.0 - 2018-03-04

  • A trace option is now available in all modes. The format roughly follows the Ruby trace format.
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@greysteil
Copy link
Contributor

This should be totally fine - tests would be failing if not.

The changelog entry for v3.0.0 is here - not much detail, but it looks like 3.0.0 wasn't very breaking.

@kristinalim
Copy link
Member

It indeed looks safe to upgrade.

For testing, best to do a smoke test of these sensitive JSON usages on the staging server.

  • Stripe payment for a subscription should be processed properly
  • Product cache integrity checking should still be good (Admin > Configuration > Caching) - Status should say "OK"

@kristinalim kristinalim self-requested a review September 1, 2018 17:35
Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should hold on this one until we don't release 1.9.0. There are already too many changes.

@dependabot-preview
Copy link
Contributor Author

Superseded by #2736.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/oj-3.6.7 branch September 17, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants