Add an OFN UID column to the Users & Enterprises report #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cillian
force-pushed
the
export-ofn-uid-column
branch
from
09964a9 to
3412786
Compare
mkllnk
approved these changes
Jun 19, 2023
| describe "Users & Enterprises reports" do | ||
| include AuthenticationHelper | ||
|
|
||
| let!(:enterprise) { create(:supplier_enterprise) } |
There was a problem hiding this comment.
You are assuming that all future specs will use an enterprise. But maybe we also want to test what happens when the database is empty. I would have created this later in the it block. But your version is good for now, too.
| end | ||
|
|
||
| it "displays the report" do | ||
| find("[type='submit']").click |
There was a problem hiding this comment.
This is brittle and will fail if we ever add any other form to the page. Other specs use click_button "Go". It also looks more like what the user does.
There was a problem hiding this comment.
Good point, fixed by 41dead8
drummer83
force-pushed
the
export-ofn-uid-column
branch
from
a579333 to
8ab077b
Compare
|
Hi @cillian, After staging your PR
Great work, thank you! 🎉 This one is ready to go! Merging! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
export-ofn-uid-column.mp4
Here is what the extra column looks like in the .pdf version of the report....
Note,
SELECT enterprises.id AS ofn_uid, ...is used instead of justSELECT enterprises.id, .... This is because if you do the latter, then the translation key inconfig/locales/en.ymlisreport_header_idwhich is vague and not as clear asreport_header_ofn_uid.What should we test?
See testing steps in #10545.
Release notes
Changelog Category: User facing changes