Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cart more easily collapsible #1255

Closed
sstead opened this issue Dec 2, 2016 · 9 comments · Fixed by #4126
Closed

Make cart more easily collapsible #1255

sstead opened this issue Dec 2, 2016 · 9 comments · Fixed by #4126
Assignees

Comments

@sstead
Copy link

sstead commented Dec 2, 2016

Update by Myriam 21.05.2018

Description

When a customer clicks on cart dropdown, but then want to do some other action, the cart dropdown doesn't collapse and disturb navigation, until the user undertands that she has to click again on the cart icon and do it.

Expected Behavior

If I click outside the cart dropdown, the cart dropdown collapses.

Actual Behavior

The cart can only be collapsed by clicking on the shopping cart icon, which is annoying.

Steps to Reproduce

  1. Add some items in your cart from any shopfront
  2. Click on cart icon and see

Animated Gif/Screenshot

image

On mobile, when a User has created a shopping cart with many items, they're forced to scroll back to the top of the page to close it and continue shopping
image

Context

Cleaning up and specifying old issues.

Severity

S4. It works as expected but is a pretty annoying UX bug so keeping it as a bug. I suspect it's good first issue but needs some dev to confirm that it's easy.

Your Environment

Desktop + Mobile + Tablet
Aus/French production (retested by Myriam on French production)
Chrome

Possible Fix

If the cart dropdown is expanded from header, it should close if user clicks outside of the dropdown.

@sstead sstead added the ux label Dec 2, 2016
@sstead sstead added this to the Backlog milestone Dec 2, 2016
@sigmundpetersen sigmundpetersen removed this from the Backlog milestone Oct 23, 2017
@myriamboure myriamboure added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label May 21, 2018
@RyanH5
Copy link

RyanH5 commented Aug 21, 2018

Hi there! We're first-time contributors and were hoping to help out with this issue. We noticed nobody was assigned to it, but if there’s already a solution in progress we're happy to try helping out elsewhere. Thanks!

@myriamboure
Copy link
Contributor

Hey @RyanH5 and thanks for reaching out! Awesome if you want to contribute. I'm just wondering on that specific issue, @kirstenalarsen with the work Yuko is doing on UX I think it might affect that issue as well no? Maybe we don't need to fix that bug if we remove the cart dropdown and just send users to cart when they click on the trolley? Just want to make sure we don't make you develop something we finally are going to change super soon! But @RyanH5 if you want to contribute I will ping you on one or two other issues to drive you through some easy one that you can start with while we discuss the status of this one ;)

@myriamboure
Copy link
Contributor

myriamboure commented Aug 21, 2018

@RyanH5 I suggest for you #2414 or #1613 or #2112 or #1361 to start with for instance, so you have choices! You will find info about internationalization and how to submit a great PR on the wiki, please check it our before starting and ask if you have questions ;-) Cheers!

@kirstenalarsen
Copy link
Contributor

This has been moved to project Mobile Ready as it relates to the Epic "OFN Header" and can be dealt with alongside other changes to the Cart.

Design approved cart behaviour for Closing cart:

  • In mobile the back button (whether it be a swipe or a press action) should exit the user out of the shopping cart and return them to the page they came from.
  • In desktop tapping outside of the cart should also close the cart dropdown - Make cart more easily collapsible #1255

@kirstenalarsen
Copy link
Contributor

kirstenalarsen commented Sep 19, 2018

nb. new design for cart also includes a Close link and text

see also #2706 and #2707, zeplin: https://zpl.io/bAEMxv8

image

@myriamboure
Copy link
Contributor

I'm not sure about the hacktoberfest label on this one, @kirstenalarsen can it be done by a newbee to the project?

@sigmundpetersen
Copy link
Contributor

Yeah maybe remove both good first issue and hacktoberfest as it has become more integrated into the new design.

@kirstenalarsen
Copy link
Contributor

Yep i think it's best done alongside the design issues rather than as a standalone. have removed labels

@myriamboure myriamboure removed the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jan 21, 2019
@myriamboure
Copy link
Contributor

I've removed bug label as this is part of mobile ready feature and part of an epic already.

@kirstenalarsen kirstenalarsen added the hackathon Issues for upcoming hackathons label Apr 10, 2019
@sigmundpetersen sigmundpetersen removed the hackathon Issues for upcoming hackathons label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants