-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused playbooks #358
Remove unused playbooks #358
Conversation
playbooks/development.yml
Outdated
@@ -1,37 +0,0 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is used by scripts/provisioning-dev.sh
but I'm not sure anyone is using it but it'll come in handy when we start changing monitoring and logging settings for Postgres for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, it's used with the LXC dev setup. Do we know who actually uses it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know @enricostano and @danypr92 used to but they don't do any OFN since ages. I just wonder if I could make use of it while playing with postgres.conf soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole /scripts
folder is just for setting up LXC containers as dev environments. If nobody uses it, we can remove the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. Well lets leave it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, let me give it a try and see if it still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the deletion of development.yml
. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, that was a community contribution a few years ago. I don't think any core devs ever used it.
50525c1
to
49bb592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess this is closing #341 as well |
…d_playbooks Remove unused playbooks
Closes #347
Closes #341
Removes outdated playbooks (pending consensus).