Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused playbooks #358

Merged

Conversation

Matt-Yorkley
Copy link
Collaborator

@Matt-Yorkley Matt-Yorkley commented Mar 28, 2019

Closes #347
Closes #341

Removes outdated playbooks (pending consensus).

@@ -1,37 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is used by scripts/provisioning-dev.sh but I'm not sure anyone is using it but it'll come in handy when we start changing monitoring and logging settings for Postgres for instance.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, it's used with the LXC dev setup. Do we know who actually uses it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @enricostano and @danypr92 used to but they don't do any OFN since ages. I just wonder if I could make use of it while playing with postgres.conf soon.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole /scripts folder is just for setting up LXC containers as dev environments. If nobody uses it, we can remove the folder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Well lets leave it then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, let me give it a try and see if it still works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the deletion of development.yml. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, that was a community contribution a few years ago. I don't think any core devs ever used it.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

burn

@sigmundpetersen
Copy link
Contributor

Guess this is closing #341 as well

@sauloperez sauloperez merged commit fa28c08 into openfoodfoundation:master Apr 3, 2019
jsia9 pushed a commit to jsia9/ofn-install that referenced this pull request Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants