Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old playbooks #347

Closed
Matt-Yorkley opened this issue Mar 26, 2019 · 6 comments
Closed

Remove old playbooks #347

Matt-Yorkley opened this issue Mar 26, 2019 · 6 comments
Assignees

Comments

@Matt-Yorkley
Copy link
Collaborator

We've got some old playbooks lying around that can probably be removed.

  • update_ruby.yml
  • verify.yml

This was mentioned as part of the coopdevs team looking at the upgrade to Ubuntu 18. I've had a look and I think we can scrap them.

@enricostano
Copy link
Contributor

#341

@Matt-Yorkley
Copy link
Collaborator Author

Ah, sorry! I missed that. I was just working off of a screenshot from Pau of a Trello board in Catalan. 🙈

@Matt-Yorkley
Copy link
Collaborator Author

Matt-Yorkley commented Mar 28, 2019

On further inspection, there's a few outdated playbooks here I think we should definitely 🔥, and a few I'm not sure about as I've never used them.

debug.yml
Some commented out lines, and a command that checks the database, but as the ubuntu user?
🔥 🔥 🔥

development.yml
Apparently for provisioning dev environments, but looks a bit outdated. Does anyone use this?
Keeping. Possibly in use.

import.yml
From 2016. Used for importing database dumps. Has anyone used this in the last 3 years?
🔥 ?

ruby_update.yml
An old file for updating the Ruby version on a server. I'm pretty sure if we were ever updating the Ruby version this is absolutely not how we would do it...
🔥 🔥 🔥

verify.yml (and verify role)
Another ancient playbook (and corresponding role). It's purpose seems to be to check if an instance is online, but it also has: "NOT INTENDED TO BE RUN ON A PRODUCTION SERVER" written in the comments...?
🔥 🔥 🔥

Does anyone think any of these should be kept? @mkllnk @sauloperez @enricostano

@sauloperez
Copy link
Contributor

I posted my comment about development.yml in the PR itself, I didn't see this.

@sauloperez
Copy link
Contributor

sauloperez commented Mar 28, 2019

@danypr92 what were your thoughts about ruby_update.yml? I think you mentioned it was pointless?
This is it #341

@mkllnk
Copy link
Member

mkllnk commented Mar 28, 2019

debug.yml

🔥

development.yml

Discussed on the PR, maybe useful to keep. Should be documented though.

import.yml
From 2016. Used for importing database dumps. Has anyone used this in the last 3 years?

No. Never heard of it. 🔥

ruby_update.yml

I commented on #341. 🔥

verify.yml (and verify role)

Never head of it. 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants