Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if a non-module is passed to TransformModuleFilesToModel #385

Closed
wants to merge 3 commits into from

Conversation

fsedano
Copy link
Contributor

@fsedano fsedano commented Nov 20, 2024

If a regular schema file, instead of a module, was passed to TransformModuleFilesToModel, it would crash.

Description

The change checks the metadata for the module, if it's null it returns the proper error.

References

Fixes #384

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@fsedano fsedano requested review from a team as code owners November 20, 2024 13:38
Copy link

linux-foundation-easycla bot commented Nov 20, 2024

CLA Not Signed

@molssongroup
Copy link

/easycla

@fsedano fsedano closed this by deleting the head repository Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash if a model is sent to TransformModuleFilesToModel
3 participants