Fix crash if a non-module is passed to TransformModuleFilesToModel

openfga · Nov 20, 2024 · 9633431 · 9633431
1 parent ff7db03
commit 9633431
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/pkg/go/transformer/module-to-model.go b/pkg/go/transformer/module-to-model.go
@@ -116,8 +116,15 @@ func TransformModuleFilesToModel( //nolint:funlen,gocognit,cyclop
 			}
 
 			types = append(types, typeDef.GetType())
-			typeDef.Metadata.SourceInfo = &openfgav1.SourceInfo{
-				File: module.Name,
+			if typeDef.Metadata != nil {
+				typeDef.Metadata.SourceInfo = &openfgav1.SourceInfo{
+					File: module.Name,
+				}
+			} else {
+				transformErrors = multierror.Append(transformErrors, &ModuleTransformationSingleError{
+					Msg: "file is not a module",
+				})
+				continue
 			}
 			rawTypeDefs = append(rawTypeDefs, typeDef)
 		}

diff --git a/tests/data/transformer-module/01-module-with-errors/expected_errors.json b/tests/data/transformer-module/01-module-with-errors/expected_errors.json
@@ -1,4 +1,8 @@
 [
+  {
+    "msg": "file is not a module",
+    "file":"nomodule.fga"
+  },
   {
     "msg": "duplicate condition a_check",
     "file": "org.fga",