Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix warning about --no-hardcoded-sync being printed when it shouldn't #8261

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Fix warning about --no-hardcoded-sync being printed when it shouldn't #8261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parity/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ pub fn execute_impl(cmd: RunCmd, can_restart: bool, logger: Arc<RotatingLogger>)
}

// display warning if using --no-hardcoded-sync
if !cmd.no_hardcoded_sync {
if cmd.no_hardcoded_sync {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this show this warning if you actually run --light?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is in a function that sets up the full client only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

Copy link
Contributor Author

@tomaka tomaka Mar 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the execute_impl function is run only when we start a full node. This if is never reached on the light client.

EDIT: oh, didn't see the existing answer

warn!("The --no-hardcoded-sync flag has no effect if you don't use --light");
}

Expand Down