This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix warning about --no-hardcoded-sync being printed when it shouldn't #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-pleasereview 🤓
5chdn
reviewed
Mar 29, 2018
| @@ -575,7 +575,7 @@ pub fn execute_impl(cmd: RunCmd, can_restart: bool, logger: Arc<RotatingLogger>) | |||
| } | |||
|
|
|||
| // display warning if using --no-hardcoded-sync | |||
| if !cmd.no_hardcoded_sync { | |||
| if cmd.no_hardcoded_sync { | |||
There was a problem hiding this comment.
does this show this warning if you actually run --light?
There was a problem hiding this comment.
Yeah, this is in a function that sets up the full client only.
There was a problem hiding this comment.
No, the execute_impl function is run only when we start a full node. This if is never reached on the light client.
EDIT: oh, didn't see the existing answer
tomusdrw
approved these changes
Mar 29, 2018
5chdn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tomusdrw