This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Switching sccache from local to Redis #10971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General-Beck
added
A0-pleasereview 🤓
ordian
changed the title
dvdplm
reviewed
Aug 14, 2019
.gitlab-ci.yml
Outdated
| echo "_____No logs from sccache_____"; | ||
| exit 0; | ||
| fi | ||
| - SCCACHE_REDIS=redis://:${REDIS}@172.17.0.1/0 sccache --start-server |
There was a problem hiding this comment.
Is it wise to use the explicit ip address here?
There was a problem hiding this comment.
That's a default gateway address of a Docker container-internal network (so in practice it's a mapping of host's 127.0.0.1 into a local subnet).
I guess it's safe enough, provided that we're not going to mess with Docker's networking too much in this setup.
As far as I understood from my chat with @General-Beck earlier today, there's no easy way to teach sccache to identify that IP by hostname, and there's no non-hacky lookup flow to be used instead either.
kirushik
approved these changes
Aug 14, 2019
TriplEight
reviewed
Aug 15, 2019
There was a problem hiding this comment.
Everything must work after images from paritytech/scripts#91 will be in the registry.
gabreal
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
I'm really a big fan of breaking one thing at a time.
One pr for new docker registry and another for changing the sccache makes it easier to exclude errors in the future.
Would be good to remove the wip from the title when requesting reviews.
looks good apart from that 👍
| else | ||
| echo "_____No logs from sccache_____"; | ||
| exit 0; | ||
| fi |
There was a problem hiding this comment.
so debugging will be disabled completely?
There was a problem hiding this comment.
Yep, sccache debugging was actually helpful only once.
But what's important and bugs me, is that debug log level somehow hinders sccache to communicate with redis.
Also, had to remove sccache -s as it was failing the job because it couldn't get the info from Redis. I tried some ideas, but think that in order to do that, we should install sccache to CI1 and CI2 which is not really necessary, at least for now.
TriplEight
changed the title
|
@General-Beck what is the status of this? Do you need any help sorting out the tests? |
|
@dvdplm I do the latest checks and tests. I think tomorrow we will launch |
General-Beck
added
the
A3-inprogress ⏳
ordian
added
A8-looksgood 🦄
dvdplm
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Switching cache from local to Radis * sccache -s won't work. All the images are taken from own registry * new images addresses * statisticss after stop sccache server sccache CC&CXX
niklasad1
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Switching cache from local to Radis * sccache -s won't work. All the images are taken from own registry * new images addresses * statisticss after stop sccache server sccache CC&CXX
s3krit
pushed a commit
that referenced
this pull request
Nov 11, 2019
* ropsten #6631425 foundation #8798209 (#11201) * [stable] builtin, istanbul and mordor testnet backports (#11234) * ethcore-builtin (#10850) * [builtin]: support `multiple prices and activations` in chain spec (#11039) * [chain specs]: activate `Istanbul` on mainnet (#11228) * ethcore/res: add mordor testnet configuration (#11200) * Update list of bootnodes for xDai chain (#11236) * ethcore: remove `test-helper feat` from build (#11047) * Secret store: fix Instant::now() related race in net_keep_alive (#11155) (#11159) * [stable]: backport #10691 and #10683 (#11143) * Fix compiler warning (that will become an error) (#10683) * Refactor Clique stepping (#10691) * Add Constantinople eips to the dev (instant_seal) config (#10809) * Add cargo-remote dir to .gitignore (?) * Insert explicit warning into the panic hook (#11225) * Fix docker centos build (#11226) * Update MIX bootnodes. (#11203) * Use provided usd-per-eth value if an endpoint is specified (#11209) * Add new line after writing block to hex file. (#10984) * Type annotation for next_key() matching of json filter options (#11192) (but no `FilterOption` in 2.5 so…) * Upgrade jsonrpc to latest (#11206) * [CI] check evmbin build (#11096) * Correct EIP-712 encoding (#11092) * [client]: Fix for incorrectly dropped consensus messages (#11086) * Fix block detail updating (#11015) * Switching sccache from local to Redis (#10971) * Made ecrecover implementation trait public (#11188) * [dependencies]: jsonrpc `14.0.1` (#11183) * [receipt]: add `sender` & `receiver` to `RichReceipts` (#11179) * [ethcore/builtin]: do not panic in blake2pricer on short input (#11180) * util Host: fix a double Read Lock bug in fn Host::session_readable() (#11175) * ethcore client: fix a double Read Lock bug in fn Client::logs() (#11172) * Change how RPCs eth_call and eth_estimateGas handle "Pending" (#11127) * Cleanup stratum a bit (#11161) * Upgrade to jsonrpc v14 (#11151) * SecretStore: expose restore_key_public in HTTP API (#10241)
s3krit
pushed a commit
that referenced
this pull request
Nov 11, 2019
* [CI] check evmbin build (#11096) * Correct EIP-712 encoding (#11092) * [client]: Fix for incorrectly dropped consensus messages (#11082) (#11086) * Update hardcoded headers (foundation, classic, kovan, xdai, ewc, ...) (#11053) * Add cargo-remote dir to .gitignore (?) * Update light client headers: ropsten 6631425 foundation 8798209 (#11201) * Update list of bootnodes for xDai chain (#11236) * ethcore/res: add mordor testnet configuration (#11200) * [chain specs]: activate Istanbul on mainnet (#11228) * [builtin]: support multiple prices and activations in chain spec (#11039) * [receipt]: add sender & receiver to RichReceipts (#11179) * [ethcore/builtin]: do not panic in blake2pricer on short input (#11180) * Made ecrecover implementation trait public (#11188) * Fix docker centos build (#11226) * Update MIX bootnodes. (#11203) * Insert explicit warning into the panic hook (#11225) * Use provided usd-per-eth value if an endpoint is specified (#11209) * Cleanup stratum a bit (#11161) * Add Constantinople EIPs to the dev (instant_seal) config (#10809) (already backported) * util Host: fix a double Read Lock bug in fn Host::session_readable() (#11175) * ethcore client: fix a double Read Lock bug in fn Client::logs() (#11172) * Type annotation for next_key() matching of json filter options (#11192) * Upgrade jsonrpc to latest (#11206) * [dependencies]: jsonrpc 14.0.1 (#11183) * Upgrade to jsonrpc v14 (#11151) * Switching sccache from local to Redis (#10971) * Snapshot restoration overhaul (#11219) * Add new line after writing block to hex file. (#10984) * Pause pruning while snapshotting (#11178) * Change how RPCs eth_call and eth_estimateGas handle "Pending" (#11127) * Fix block detail updating (#11015) * Make InstantSeal Instant again #11186 * Filter out some bad ropsten warp snapshots (#11247)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the images which are used in parity-ethereum build process are now being published to our Gitilab docker container registry.
These images now are making use of
sccachewith Redis to avoid the data race condition when pruning old cache pieces.Metadata was also edited to show the current addresses of the images.
test
Depends on paritytech/scripts#91