-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC_LEARNER_41] > date and course outline pages are blank #222
Comments
label: olive testing |
I believe this issue is related to the learning MFE, since the path should be: |
@mariajgrimaldi hmmm, interesting. The path So, I would expect some other step in Tutor's build pipeline to account for this by to prepending |
Thanks, @kdmccormick, for the detailed explanation! |
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
@arbrandes @mariajgrimaldi following our yesterday meeting, this issue caught my attention, so while looking into I came out with a suggested fix here openedx/frontend-app-learning/pull/1009. The way my fix work is by getting urls of the tabs from the state, simlair to how TabNavigation gets them, which orginally gets them from coursemetadata API. |
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
Thank you @ghassanmas! I left you a comment in the PR :) |
[Edit] Sorry I meant to reply on the PR, but got overwhelmed by github notifcation 🙈 I tested this on production with tutor on my demo instance at olive.zaat.dev and it worked as expected, but in anycase, to debug this could you when loading the learning MFE check the network logs in for the result of this call:
For example in my demo instance I for
I get this {
"can_show_upgrade_sock": false,
"verified_mode": null,
"celebrations": {
"first_section": false,
"streak_length_to_celebrate": null,
"streak_discount_enabled": false,
"weekly_goal": false
},
"course_access": {
"has_access": true,
"error_code": null,
"developer_message": null,
"user_message": null,
"additional_context_user_message": null,
"user_fragment": null
},
"course_id": "course-v1:zaatdev+101+1",
"is_enrolled": true,
"is_self_paced": true,
"is_staff": true,
"number": "101",
"org": "zaatdev",
"original_user_is_staff": true,
"start": "2022-12-05T00:00:00Z",
"tabs": [
{
"tab_id": "courseware",
"title": "Course",
"url": "https://apps.olive.zaat.dev/learning/course/course-v1:zaatdev+101+1/home"
},
{
"tab_id": "progress",
"title": "Progress",
"url": "https://apps.olive.zaat.dev/learning/course/course-v1:zaatdev+101+1/progress"
},
{
"tab_id": "dates",
"title": "Dates",
"url": "https://apps.olive.zaat.dev/learning/course/course-v1:zaatdev+101+1/dates"
},
{
"tab_id": "wiki",
"title": "Wiki",
"url": "https://olive.zaat.dev/courses/course-v1:zaatdev+101+1/course_wiki"
},
{
"tab_id": "instructor",
"title": "Instructor",
"url": "https://olive.zaat.dev/courses/course-v1:zaatdev+101+1/instructor"
}
],
"title": "Olive Demo",
"username": "admin",
"user_timezone": null,
"can_view_certificate": true
}
|
I'm not sure what's wrong with my setup then. Either way, can you add an image similar to this one? So we have a record that it's working. Thanks again! |
I am not very good with photo editing, but here is an attempt screenshot when I hoverovered the dates in progress You can try it with https://olive.zaat.dev email: [email protected] password: admin |
@ghassanmas thank you! ❤️ |
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
This fix does fixes the url links by getting them from the state simliar to how tabs navigation gets them. This would allow it work for PUBLIC_PATH is not '/', i.e. in tutor. This was reported in openedx/wg-build-test-release/issues/222
Fixed! Thanks, @ghassanmas! |
Steps to reproduce:
date
andcourse outline
pagesExpected result:
Pages should have some data in them.
Actual result:
Pages are blank
PRs
The text was updated successfully, but these errors were encountered: