Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tabs urls on progress tab #1011

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: fix tabs urls on progress tab #1011

merged 1 commit into from
Dec 7, 2022

Conversation

ghassanmas
Copy link
Member

@ghassanmas
fix: fix tabs urls on progress tab
27c69ba 
 This fix does fixes the url links by getting them from the state
 simliar to how tabs navigation gets them.

 This would allow it work for PUBLIC_PATH is not '/', i.e. in
 tutor.

  This was reported in openedx/wg-build-test-release/issues/222
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 7, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ghassanmas ghassanmas mentioned this pull request Dec 7, 2022
Closed
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (open-release/olive.master@77e3b17). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##             open-release/olive.master    #1011   +/-   ##
============================================================
  Coverage                             ?   84.25%           
============================================================
  Files                                ?      264           
  Lines                                ?     4554           
  Branches                             ?     1178           
============================================================
  Hits                                 ?     3837           
  Misses                               ?      697           
  Partials                             ?       20

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

arbrandes
arbrandes approved these changes Dec 7, 2022
View reviewed changes
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arbrandes arbrandes merged commit 17a102d into openedx:open-release/olive.master Dec 7, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@arbrandes arbrandes mentioned this pull request Dec 7, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghassanmas @openedx-webhooks @arbrandes