fix: show multiView enabled xBlocks on mobile only #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
requested review from
k1rill,
farhan-arshad-dev,
HamzaIsrar12 and
volodymyr-chekyrta
HamzaIsrar12
requested changes
Dec 11, 2023
| } | ||
|
|
||
| data class StudentViewData( | ||
| val onlyOnWeb: Boolean, | ||
| val duration: Any, | ||
| val transcripts: HashMap<String, String>?, | ||
| val encodedVideos: EncodedVideos?, | ||
| val topicId: String, | ||
| val topicId: String?, |
There was a problem hiding this comment.
Please revert this as we are already setting it to blank in the data layer.
| val transcripts = block.studentViewData!!.transcripts | ||
| return when { | ||
| (block.isVideoBlock && block.studentViewData?.encodedVideos != null) -> { | ||
| val encodedVideos = block.studentViewData?.encodedVideos |
There was a problem hiding this comment.
Please also revert changes in this block.
omerhabib26
force-pushed
the
omer/LEARNER-9699
branch
from
3569be8
to
1393a28
Compare
HamzaIsrar12
approved these changes
Dec 11, 2023
omerhabib26
force-pushed
the
omer/LEARNER-9699
branch
from
044da26
to
049ec14
Compare
- Update conditions for components to show only enabled multiview xBlocks on mobile fix: LEARNER-9699
- Add checks to show appropriate view in case studentViewData is NullOrEmpty
k1rill
approved these changes
Dec 12, 2023
volodymyr-chekyrta
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
studentViewDatafor Video and Discussions blockfix: #85 / LEARNER-9699