Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] [Android] X-Blocks are showing that student_view_multi_device is set to false #85

Closed
Tracked by #90
moiz994 opened this issue Nov 6, 2023 · 4 comments
Closed
Tracked by #90

[Mobile] [Android] X-Blocks are showing that student_view_multi_device is set to false #85

moiz994 opened this issue Nov 6, 2023 · 4 comments
Assignees
@HamzaIsrar12
Labels
bug Report of or fix for something that isn't working as intended

Comments

@moiz994
Copy link

moiz994 commented Nov 6, 2023

The app displays HTML blocks for which student_view_multi_device is set to false, which it shouldn't.

Acceptance Criteria

  • The app shouldn’t display the blocks/components in which student_view_multi_device is set to false.
  • Make competent navigation parity with the iOS app.
@moiz994 moiz994 mentioned this issue Nov 6, 2023
Closed
@moiz994 moiz994 moved this to In Development in Open edX Mobile Roadmap Nov 7, 2023
@marcotuts
Copy link
Contributor

What does this flag do, is this the 'do not show on mobile' setting?

@moiz994
Copy link
Author

moiz994 commented Nov 8, 2023

Yes, I believe so.
@HamzaIsrar12 please correct me if I'm wrong.

@HamzaIsrar12
Copy link
Contributor

You are right, Moiz. If this flag is true for an HTML block, we won't display that XBlock on mobile. Instead, we'll show a "View on Web" or "Not Available on Mobile" type screen.

@marcotuts marcotuts mentioned this issue Nov 10, 2023
Closed
@moiz994 moiz994 added the bug Report of or fix for something that isn't working as intended label Dec 6, 2023
@omerhabib26 omerhabib26 mentioned this issue Dec 11, 2023
Merged
@marcotuts
Copy link
Contributor

This can be closed now that PR 158 has merged is my understanding. closing for now, lmk if that is odd / incomplete!

@github-project-automation github-project-automation bot moved this from In Development to Done in Open edX Mobile Roadmap Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HamzaIsrar12 HamzaIsrar12

Labels
bug Report of or fix for something that isn't working as intended
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcotuts @HamzaIsrar12 @moiz994