-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Accept OEP-58 as it has been implemented #610
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ OEP-58: Translations Management | |
| * - Title | ||
| - Translations Management | ||
| * - Last Modified | ||
| - 2022-11-22 | ||
| - 2024-07-25 | ||
| * - Authors | ||
| - | ||
| * Carlos Muniz <[email protected]> | ||
|
|
@@ -18,15 +18,18 @@ OEP-58: Translations Management | |
| * - Arbiter | ||
| - Ned Batchelder <[email protected]> | ||
| * - Status | ||
| - Provisional | ||
| - Accepted | ||
| * - Type | ||
| - Architecture Decision | ||
| * - Created | ||
| - 2022-08-08 | ||
| * - Review Period | ||
| - 2022-11-07 - 2022-11-21 | ||
| * - References | ||
| - `Follow-up Work <https://openedx.atlassian.net/wiki/spaces/COMM/pages/3578494977/Translations+Management+Design+Implementation>`_ | ||
| - | ||
| * `Concept doc about translations <https://docs.openedx.org/en/latest/translators/concepts/translation-process.html>`_ | ||
| * `Enabling translations on a new repo <https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html>`_ | ||
| * `Follow-up Work <https://openedx.atlassian.net/wiki/spaces/COMM/pages/3578494977/Translations+Management+Design+Implementation>`_ | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
@@ -264,6 +267,19 @@ debugging issues or tracking the progress of each Transifex Project time-consumi | |
| addition, the Transifex editor does not support editing strings across multiple projects | ||
| making it extremely time consuming for users to translate strings from many projects. | ||
|
|
||
| Change History | ||
| ************** | ||
|
|
||
| 2024-07-25 | ||
| ========== | ||
| * Mark OEP as "Accepted", due to the full implementation of the proposal | ||
| * `Pull request #610 <https://github.com/openedx/open-edx-proposals/pull/610>`_ | ||
|
|
||
| 2022-08-08 | ||
| ========== | ||
| * Document created | ||
| * `Pull request #367 <https://github.com/openedx/open-edx-proposals/pull/367>`_ | ||
|
|
||
| .. _ecommerce-scripts: https://github.com/openedx/ecommerce-scripts/tree/master/transifex | ||
| .. _edx-platform: https://github.com/openedx/edx-platform | ||
| .. _openedx-atlas: https://github.com/openedx/openedx-atlas | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this link be left here? Has this wiki page been fully addressed or is there work left to do? I think there may be work on that page that has not been completed, but I don't see it as work that is blocking the acceptance of this OEP. Perhaps the wiki page could be narrowed to unimplemented details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comments to https://openedx.atlassian.net/wiki/spaces/COMM/pages/3578494977/Translations+Management+Design+Implementation
@OmarIthawi would you mind taking a look at that wiki page as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll take a look. Sorry for keeping this stale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina
The wiki are a bit outdated and the three of the links need more work.
I'm pushing a PR to make it less outdated by fixing things locally. We may still need to refactor the docs to become more digestable.
Is it just me or the documentation work is hard?