Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-26][EDUCATOR-5813] Add pages for pending/failed prerequisites #11

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented May 26, 2021

This PR adds pages for failed/pending prerequisites if user has any

NOTE: should be merged after #10

JIRA: EDUCATOR-5813

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program community manager review labels May 26, 2021
@openedx-webhooks
Copy link

openedx-webhooks commented May 26, 2021

Thanks for the pull request, @viktorrusakov! I've created BLENDED-856 to keep track of it in Jira. More details are on the BD-26 project page.

When this pull request is ready, tag your edX technical lead.

@zacharis278
Copy link
Contributor

can you do a rebase to catch us up with previous changes? hard to view the diff otherwise

@viktorrusakov viktorrusakov force-pushed the rusakov/EDUCATOR-5813/prerequisites-pages branch from 9c59a60 to aef5a07 Compare May 31, 2021 09:54
@viktorrusakov
Copy link
Contributor Author

@zacharis278 this should be merged after #10

@zacharis278
Copy link
Contributor

@viktorrusakov new views and tests look good, will give a thumb once we've resolved the conflicts

@viktorrusakov viktorrusakov force-pushed the rusakov/EDUCATOR-5813/prerequisites-pages branch from aef5a07 to 661c665 Compare June 3, 2021 18:41
@viktorrusakov
Copy link
Contributor Author

@zacharis278 updated the branch, ready to be merged now. Also please check out PRs in edx-proctoring, mainly this and this, since they both correspond to the two PRs being merged here today

@viktorrusakov
Copy link
Contributor Author

I have also noted the issues from previous PR, I will bring them up tomorrow in our internal sync so we can keep them in mind and get it fixed

@zacharis278 zacharis278 merged commit 3106b5a into openedx:main Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants