[BD-26][EDUCATOR-5761, EDUCATOR-5762] Add additional pages for proctored exams #10

viktorrusakov · 2021-05-26T18:04:17Z

This PR adds following pages for proctoring exam flow: user verification, system check, ready to start instructions

NOTE: should be merged first

…ngs and instructions

…_start' status)

…ng exam instructions (#14) Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Sagirov Evgeniy <[email protected]>

…#16) * feat: Cover timed exam functionality with unit and functional tests

… and support for js workers from provider (#20) * feat: add handling of exam API errors * feat: add support for workers from proctoring providers

…ding on the frontend

openedx-webhooks · 2021-05-26T18:04:23Z

Thanks for the pull request, @viktorrusakov! I've created BLENDED-855 to keep track of it in Jira. More details are on the BD-26 project page.

When this pull request is ready, tag your edX technical lead.

zacharis278 · 2021-05-27T19:09:26Z

can you update this with the commits from main?

viktorrusakov · 2021-06-01T13:31:36Z

@zacharis278 review please, this one should be merged first

zacharis278

The new views themselves look good but there's a few things I noticed while going through the code.

It seems like we're doubling up API calls to the backend for review policy and settings (it's not just OPTIONS requests but multiple GETS)
If the settings call fails I seem to get an infinite loading animation. (this can definitely be fixed in another PR)
I'm going to take a detailed look at the tests later for what's important but based on codecov it seems like our coverage is lacking.

zacharis278 · 2021-06-02T15:01:20Z

src/data/thunks.js

@@ -168,7 +175,7 @@ export function stopExam() {
  };
 }

-export function continueExam() {
+export function continueExam(noLoading = true) {


this is mostly a comment on the existing code here. This continue exam flow isn't making much sense to me, why do we need to make a backend call with a start action?

I think this is mainly used when you are on ready_to_submit page and instead of clicking 'submit' you click 'continue my exam', then this function gets called (this is also how it is done in LMS)

Also in this PR this function is used to start proctored exam (I'm not sure why I did this) but it gets refactored in #14

zacharis278 · 2021-06-02T15:03:23Z

src/data/slice.js

@@ -9,6 +9,7 @@ export const examSlice = createSlice({
    activeAttempt: null,
    proctoringSettings: {},
    exam: {},
+    verification: {},


it would be nice to scaffold out the entire model for each of these backend models so developers know what the data will look like. (proctoringSettings, exam, verification)

We will create tests for redux later and I believe we will have snapshots / factories for our data, will it work or do you mean something else?

I'd hoped to see something more like this for each model

verification: { status: '', can_verify: false, }, ...

let's follow up in another PR since I've merged this already.

viktorrusakov · 2021-06-03T09:06:52Z

The new views themselves look good but there's a few things I noticed while going through the code.

It seems like we're doubling up API calls to the backend for review policy and settings (it's not just OPTIONS requests but multiple GETS)

If the settings call fails I seem to get an infinite loading animation. (this can definitely be fixed in another PR)

I'm going to take a detailed look at the tests later for what's important but based on codecov it seems like our coverage is lacking.

Are you sure that review policy API gets called multiple times? I think this is true only for proctoring settings and verification data API calls, and they are both being addressed in our other PRs (verification data calls are currently addressed in our internal PR here and proctoring settings in [BD-26] Fix a bug with JS worker #14). That was my bad, I should have noticed it during this PR, but I noticed much later...
Yes, we missed that, one of the previous PRs was dealing with handling such errors properly but at the time we didn't have settings API and some others and when we added them we forgot to add functionality of that PR to new API calls. We will create another PR later to make sure every API call is handled correctly.
There are more tests added in [BD-26] feat: add test coverage for all instructions #12, so coverage should get better. Note that these tests are only for components, we are planning to add tests for redux soon which will cover our store / API functionality.

zacharis278 · 2021-06-03T14:38:49Z

So it looks like this is only happening when you load the page directly in a ready_to_start state but not when the state transitions. We can fix it later.

I'm going to go ahead and merge this in and keep track of things we may need to fix as we go

github-actions · 2021-06-03T19:30:46Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ihor-romaniuk and others added 14 commits May 21, 2021 15:26

feat: [OeX_Proctoring-178] add mock api for fetching proctoring setti…

ba7ed5a

…ngs and instructions

feat: use API instead of mocked data to get proctoring settings

e6018ee

feat: add proctoring software download page + refactor footer

ad8276f

feat: add user verification page

6f5f35b

feat: add proctored exam instructions page (when exam is in 'ready_to…

73c2908

…_start' status)

feat: [OeX_Proctoring-178] fetch proctoring settings and add proctori…

eca5fab

…ng exam instructions (#14) Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Sagirov Evgeniy <[email protected]>

[BD-26] Cover timed exam functionality with unit and functional tests (…

4eada74

…#16) * feat: Cover timed exam functionality with unit and functional tests

fix: don't do pulling when exam is in 'ready_to_submit' status (#19)

d3ebbaa

[BD-26][EDUCATOR-5791, EDUCATOR-5767] Add handling of exam API errors…

cd2e391

… and support for js workers from provider (#20) * feat: add handling of exam API errors * feat: add support for workers from proctoring providers

feat: get provider software download url from backend instead of buil…

f20fbb7

…ding on the frontend

Merge branch 'main' into rusakov/EDUCATOR-5761/proctoring-pages

e876db3

fix: merge errors

9eec38d

fix: fix tests

809b88d

feat: add verification url to user verification page

c51257b

openedx-webhooks added blended PR is managed through 2U's blended developmnt program community manager review labels May 26, 2021

viktorrusakov mentioned this pull request May 26, 2021

[BD-26][EDUCATOR-5813] Add pages for pending/failed prerequisites #11

Merged

viktorrusakov force-pushed the rusakov/EDUCATOR-5761/proctoring-pages branch 2 times, most recently from c74970c to c51257b Compare May 31, 2021 08:53

Merge branch 'main' into rusakov/EDUCATOR-5761/proctoring-pages

15f21de

zacharis278 reviewed Jun 2, 2021

View reviewed changes

zacharis278 merged commit addb8f8 into openedx:main Jun 3, 2021

openedx-webhooks added merged and removed community manager review labels Jun 3, 2021

github-actions bot added the released label Jun 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BD-26][EDUCATOR-5761, EDUCATOR-5762] Add additional pages for proctored exams #10

[BD-26][EDUCATOR-5761, EDUCATOR-5762] Add additional pages for proctored exams #10

viktorrusakov commented May 26, 2021 •

edited

Loading

openedx-webhooks commented May 26, 2021 •

edited

Loading

zacharis278 commented May 27, 2021

viktorrusakov commented Jun 1, 2021

zacharis278 left a comment

zacharis278 Jun 2, 2021

viktorrusakov Jun 3, 2021

zacharis278 Jun 2, 2021

viktorrusakov Jun 3, 2021

zacharis278 Jun 3, 2021

viktorrusakov commented Jun 3, 2021 •

edited

Loading

zacharis278 commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

[BD-26][EDUCATOR-5761, EDUCATOR-5762] Add additional pages for proctored exams #10

[BD-26][EDUCATOR-5761, EDUCATOR-5762] Add additional pages for proctored exams #10

Conversation

viktorrusakov commented May 26, 2021 • edited Loading

openedx-webhooks commented May 26, 2021 • edited Loading

zacharis278 commented May 27, 2021

viktorrusakov commented Jun 1, 2021

zacharis278 left a comment

Choose a reason for hiding this comment

zacharis278 Jun 2, 2021

Choose a reason for hiding this comment

viktorrusakov Jun 3, 2021

Choose a reason for hiding this comment

zacharis278 Jun 2, 2021

Choose a reason for hiding this comment

viktorrusakov Jun 3, 2021

Choose a reason for hiding this comment

zacharis278 Jun 3, 2021

Choose a reason for hiding this comment

viktorrusakov commented Jun 3, 2021 • edited Loading

zacharis278 commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

viktorrusakov commented May 26, 2021 •

edited

Loading

openedx-webhooks commented May 26, 2021 •

edited

Loading

viktorrusakov commented Jun 3, 2021 •

edited

Loading