Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: referencing activeStatus for undefined #943

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: referencing activeStatus for undefined #943

merged 1 commit into from
Apr 10, 2024

Conversation

KristinAoki
Copy link
Member

Description

This PR fixes a undefined bug when deleting files with new Delete Confirmation Modal #938 (See PR for full details)

Testing instructions

  1. Navigate to the Files page
  2. Select a file to delete
  3. Should open delete confirmation with the file name is the title
  4. Click "Delete"
  5. Should successfully delete and close delete modal

@KristinAoki KristinAoki requested a review from a team as a code owner April 10, 2024 18:24
@KristinAoki KristinAoki merged commit fd6b9ae into master Apr 10, 2024
4 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-undefined-activeStatus-error branch April 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayzhou-bit rayzhou-bit rayzhou-bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristinAoki @rayzhou-bit