Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include usage locations in delete modal #938

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

KristinAoki
Copy link
Member

Description

This PR enhances the details in the files and videos delete confirmation. The new details clarify that deleting content can impact the rendering of the course if used in advanced settings, units, etc. Additional added a list of collapsible sections for the files/videos that are used in units so that users are aware that the files/videos that they are trying to delete might mess up content. This change impacts Authors.

Before
Screenshot 2024-04-05 at 4 06 46 PM

After
Screenshot 2024-04-05 at 4 04 27 PM

Supporting information

JIRA Ticket: TNL-10957

Testing instructions

  1. Navigate to the Files page
  2. Select a file to delete that is not used in a course
  3. Should open delete confirmation with the file name is the title
  4. Should not show the list of files that are used in the course
  5. Click "Cancel"
  6. Select a file to delete that is used in acourse
  7. Should open delete confirmation with the file name is the title
  8. Should show the list of files that are used in the course
  9. Click "Cancel"
  10. Select multiple files
  11. Should number of selected files in the title
  12. Should show files that are used in the course listed
  13. Should not show files that are not used in the course

@KristinAoki KristinAoki requested a review from a team as a code owner April 5, 2024 20:07
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (99a144a) to head (355610c).
Report is 4 commits behind head on master.

❗ Current head 355610c differs from pull request most recent head c5dfbe3. Consider uploading reports for the commit c5dfbe3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   92.00%   92.01%   +0.01%     
==========================================
  Files         612      613       +1     
  Lines       10746    10761      +15     
  Branches     2305     2308       +3     
==========================================
+ Hits         9887     9902      +15     
  Misses        830      830              
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one nit

Co-authored-by: connorhaugh <[email protected]>
@KristinAoki KristinAoki enabled auto-merge (squash) April 9, 2024 15:05
@KristinAoki KristinAoki merged commit fdcda98 into master Apr 10, 2024
4 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/update-file-delete-modal-messaging branch April 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants