Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling fix to Calculator setting dialog. #160

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

saadyousafarbi
Copy link
Contributor

TNL-8480

Description

Styling fix for Calculator setting dialog.

Before

Screen Shot 2021-07-12 at 9 11 41 PM

After

Screen Shot 2021-07-12 at 9 03 07 PM

@codecov-commenter
Copy link

Codecov Report

Merging #160 (2a82d51) into master (e23e8e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   68.56%   68.56%           
=======================================
  Files          75       75           
  Lines        1091     1091           
  Branches      211      211           
=======================================
  Hits          748      748           
  Misses        338      338           
  Partials        5        5           
Impacted Files Coverage Δ
src/generic/FormSwitchGroup.jsx 100.00% <ø> (ø)
...-resources/app-settings-modal/AppSettingsModal.jsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23e8e8...2a82d51. Read the comment docs.

Copy link
Contributor

@mehaknasir mehaknasir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saadyousafarbi saadyousafarbi merged commit b1c0bca into master Jul 15, 2021
@saadyousafarbi saadyousafarbi deleted the saad/TNL-8480 branch July 15, 2021 13:20
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
fix: editor title editing no longer tries to scale with input size. TNL-10236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants