fix: discard button [FC-0062]

[navinkarkera]

Related PRs:

• fix: delete discarded components from meilisearch index [FC-0062] edx-platform#35243
• feat: option to include deleted drafts while fetching unpublished entities [FC-0062] openedx-learning#207

Issue: #1200

Test instructions:

• Setup latest tutor nightly locally.
• Install https://github.com/open-craft/tutor-contrib-meilisearch and enable the plugin
• Checkout above PRs from edx-platform and openedx-learning.
• Mount both the directories in tutor using tutor mounts add <path>.
• Start tutor using tutor dev launch -I
• Go to studio -> Libraries and create a new library.
• Create some components and click on publish button in the sidebar.
• Verify that everything is saved.
• Add some more components and click on Discard changes button in sidebar.
• Verify that newly created components are not visible.

Original PR and comments: open-craft#58

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

GROVE_REDIRECTS:
 - domain: {{ LMS_HOST }}
 - domain: cms.{{ LMS_HOST }}
 - domain: app.{{ LMS_HOST }}
 - domain: meilsearch.{{ LMS_HOST }}

PLUGINS:
- mfe
- grove
- s3
- meilisearch

OPENEDX_EXTRA_PIP_REQUIREMENTS:
- dnspython
- openedx-scorm-xblock<13.0.0,>=12.0.0
- git+https://github.com/openedx/openedx-learning@main

Tutor requirements

git+https://github.com/overhangio/tutor.git@nightly
git+https://github.com/overhangio/tutor-mfe@nightly
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main
git+https://github.com/open-craft/tutor-contrib-meilisearch.git@main
git+https://github.com/hastexo/[email protected]

[openedx-webhooks]

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (7c59b4a) to head (2b061f2).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1214   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         756      756           
  Lines       13653    13664   +11     
  Branches     2953     2905   -48     
=======================================
+ Hits        12696    12707   +11     
- Misses        921      922    +1     
+ Partials       36       35    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisChV]

@navinkarkera Looks good, great work 👍

• I tested this: I followed the testing instructions. I tested with a new library, a tested after publish a library and I tested the discard changes with multiple updates
• I read through the code and considered the security, stability and performance implications of the changes.
• I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
• Includes tests for bugfixes and/or features added.
• Includes documentation
• Includes fixtures that create objects required for manual testing.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[openedx-webhooks]

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.