fix: delete discarded components from meilisearch index [FC-0062]

[navinkarkera]

Description

Reverting a library to its last published state is done by calling revert_changes view, which triggers CONTENT_LIBRARY_UPDATED signal. This PR updates the task that is triggered to also delete newly created components which were never published from the meilisearch index.

This PR includes three ways of updating the index:

• 970736f & 06e4c5d fetches draft components that have version = null and explicitly removes them the index. One drawback here is that if the number of components having draft version = null increase, this technique will try to delete them on each discard/publish even if they don't exists in the index.
• 30ea189 deletes all documents for a given library in the index. This works but it also deletes components which do have draft version and adds them back.
• 2ec9070 only deletes components that were never published after the publish or discard request.

Supporting information

• Discard changes on Library Info Sidebar breaks the library frontend-app-authoring#1200
• fix: discard changes [FC-0062] open-craft/frontend-app-authoring#58 fix: discard button [FC-0062] frontend-app-authoring#1214
• feat: option to include deleted drafts while fetching unpublished entities [FC-0062] openedx-learning#207

Testing instructions

See open-craft/frontend-app-authoring#58 for instructions on testing.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
• If your database migration can't be rolled back easily.

[openedx-webhooks]

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[ChrisChV]

@navinkarkera Looks good 👍

• I tested this: I followed the testing instructions on fix: discard changes [FC-0062] open-craft/frontend-app-authoring#58 (review)
• I read through the code and considered the security, stability and performance implications of the changes.
• Includes tests for bugfixes and/or features added.
• Includes documentation

[openedx-webhooks]

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.