refactor: Update error message while adding library team member [FC-0062] #1572
Conversation
|
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
ChrisChV
force-pushed
the
chris/update-error-msg-library-member
branch
from
33c0e96 to
3c42def
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 1075 1075
Lines 21190 21194 +4
Branches 4554 4556 +2
=======================================
+ Hits 19700 19704 +4
+ Misses 1424 1418 -6
- Partials 66 72 +6 ☔ View full report in Codecov by Sentry. |
| const url = getLibraryTeamApiUrl(libraryId); | ||
| const axiosMock = new MockAdapter(getAuthenticatedHttpClient()); | ||
| axiosMock.onPost(url).reply(400, { email: 'Error' }); | ||
| axiosMock.onPost(url).reply(400, { email: 'This is an specific error.' }); |
There was a problem hiding this comment.
| axiosMock.onPost(url).reply(400, { email: 'This is an specific error.' }); | |
| axiosMock.onPost(url).reply(400, { email: 'This is a specific error.' }); |
| @@ -204,7 +204,7 @@ describe('<LibraryTeam />', () => { | |||
| }); | |||
|
|
|||
| expect(await screen.findByText( | |||
| 'Error adding Team Member. Please verify that the email is correct and belongs to a registered user.', | |||
| 'Error adding Team Member. This is an specific error.', | |||
There was a problem hiding this comment.
| 'Error adding Team Member. This is an specific error.', | |
| 'Error adding Team Member. This is a specific error.', |
| addMemberSpecificError: { | ||
| id: 'course-authoring.library-authoring.library-team.add-member-specific-error', | ||
| defaultMessage: 'Error adding Team Member. {message}', | ||
| description: 'Message shown when an error occurs with an specific error while adding a Library Team member.', |
There was a problem hiding this comment.
| description: 'Message shown when an error occurs with an specific error while adding a Library Team member.', | |
| description: 'Message shown when an error occurs while adding a Library Team member, including a specific error message.', |
Update the error message while adding a library team member to show the error message generated by the server
Supporting information
Testing instructions
Other information
N/A