refactor: Update error message while adding library team member

openedx · Dec 16, 2024 · 3c42def · 3c42def
1 parent b110b6b
commit 3c42def
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/src/library-authoring/library-team/LibraryTeam.test.tsx b/src/library-authoring/library-team/LibraryTeam.test.tsx
@@ -183,10 +183,10 @@ describe('<LibraryTeam />', () => {
     expect(await screen.findByText('Team Member added')).toBeInTheDocument();
   });
 
-  it('shows error when user do not exist', async () => {
+  it('shows error when specific error', async () => {
     const url = getLibraryTeamApiUrl(libraryId);
     const axiosMock = new MockAdapter(getAuthenticatedHttpClient());
-    axiosMock.onPost(url).reply(400, { email: 'Error' });
+    axiosMock.onPost(url).reply(400, { email: 'This is an specific error.' });
 
     await renderLibraryTeam();
 
@@ -204,7 +204,7 @@ describe('<LibraryTeam />', () => {
     });
 
     expect(await screen.findByText(
-      'Error adding Team Member. Please verify that the email is correct and belongs to a registered user.',
+      'Error adding Team Member. This is an specific error.',
     )).toBeInTheDocument();
   });
 

diff --git a/src/library-authoring/library-team/LibraryTeam.tsx b/src/library-authoring/library-team/LibraryTeam.tsx
@@ -68,7 +68,16 @@ const LibraryTeam: React.FC<Record<never, never>> = () => {
       }).catch((addMemberError) => {
         const errorData = typeof addMemberError === 'object' ? addMemberError.response?.data : undefined;
         if (errorData && 'email' in errorData) {
-          showToast(intl.formatMessage(messages.addMemberEmailError));
+          const errorEmail = errorData.email;
+          if (typeof errorEmail === 'string') {
+            showToast(intl.formatMessage(messages.addMemberSpecificError, {
+              message: errorEmail,
+            }));
+          } else {
+            showToast(intl.formatMessage(messages.addMemberSpecificError, {
+              message: errorEmail[0],
+            }));
+          }
         } else {
           showToast(intl.formatMessage(messages.addMemberError));
         }

diff --git a/src/library-authoring/library-team/messages.ts b/src/library-authoring/library-team/messages.ts
@@ -124,10 +124,10 @@ const messages = defineMessages({
     defaultMessage: 'Error adding Team Member',
     description: 'Message shown when an error occurs while adding a Library Team member',
   },
-  addMemberEmailError: {
-    id: 'course-authoring.library-authoring.library-team.add-member-email-error',
-    defaultMessage: 'Error adding Team Member. Please verify that the email is correct and belongs to a registered user.',
-    description: 'Message shown when an error occurs with email while adding a Library Team member.',
+  addMemberSpecificError: {
+    id: 'course-authoring.library-authoring.library-team.add-member-specific-error',
+    defaultMessage: 'Error adding Team Member. {message}',
+    description: 'Message shown when an error occurs with an specific error while adding a Library Team member.',
   },
   deleteMemberSuccess: {
     id: 'course-authoring.library-authoring.library-team.delete-member-success',