-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update error message while adding library team member [FC-0062] #1572
Merged
ChrisChV
merged 2 commits into
openedx:master
from
open-craft:chris/update-error-msg-library-member
Dec 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -183,10 +183,10 @@ describe('<LibraryTeam />', () => { | |||||
expect(await screen.findByText('Team Member added')).toBeInTheDocument(); | ||||||
}); | ||||||
|
||||||
it('shows error when user do not exist', async () => { | ||||||
it('shows error when specific error', async () => { | ||||||
const url = getLibraryTeamApiUrl(libraryId); | ||||||
const axiosMock = new MockAdapter(getAuthenticatedHttpClient()); | ||||||
axiosMock.onPost(url).reply(400, { email: 'Error' }); | ||||||
axiosMock.onPost(url).reply(400, { email: 'This is an specific error.' }); | ||||||
|
||||||
await renderLibraryTeam(); | ||||||
|
||||||
|
@@ -204,7 +204,7 @@ describe('<LibraryTeam />', () => { | |||||
}); | ||||||
|
||||||
expect(await screen.findByText( | ||||||
'Error adding Team Member. Please verify that the email is correct and belongs to a registered user.', | ||||||
'Error adding Team Member. This is an specific error.', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
)).toBeInTheDocument(); | ||||||
}); | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -124,10 +124,10 @@ const messages = defineMessages({ | |||||
defaultMessage: 'Error adding Team Member', | ||||||
description: 'Message shown when an error occurs while adding a Library Team member', | ||||||
}, | ||||||
addMemberEmailError: { | ||||||
id: 'course-authoring.library-authoring.library-team.add-member-email-error', | ||||||
defaultMessage: 'Error adding Team Member. Please verify that the email is correct and belongs to a registered user.', | ||||||
description: 'Message shown when an error occurs with email while adding a Library Team member.', | ||||||
addMemberSpecificError: { | ||||||
id: 'course-authoring.library-authoring.library-team.add-member-specific-error', | ||||||
defaultMessage: 'Error adding Team Member. {message}', | ||||||
description: 'Message shown when an error occurs with an specific error while adding a Library Team member.', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
deleteMemberSuccess: { | ||||||
id: 'course-authoring.library-authoring.library-team.delete-member-success', | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.