refactor: Completely remove Blockstore #34739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/rm-blockstore
branch
2 times, most recently
from
b05b57d
to
e4aea09
Compare
ormsbee
approved these changes
May 9, 2024
| # In the future, we need a way to use file_wrapper.chunks() to read | ||
| # the file in chunks and stream that to Blockstore, but Blockstore | ||
| # currently lacks an API for streaming file uploads. | ||
| # Ref: https://github.com/openedx/edx-platform/issues/34737 |
There was a problem hiding this comment.
We'll still need some kind of base checking to make sure it's not over our size limit, and we'll probably want to support streaming at some point.
kdmccormick
force-pushed
the
kdmccormick/rm-blockstore
branch
2 times, most recently
from
8e2b40c
to
ba152fc
Compare
kdmccormick
force-pushed
the
kdmccormick/rm-blockstore
branch
from
ba152fc
to
752ce32
Compare
Commit generated by workflow `kdmccormick/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: Kyle McCormick <[email protected]>
kdmccormick
force-pushed
the
kdmccormick/rm-blockstore
branch
from
752ce32
to
e0037b3
Compare
kdmccormick
changed the title
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
ormsbee
added a commit
to ormsbee/openedx-tutor-plugins
that referenced
this pull request
May 16, 2024
Blockstore was completely removed from edx-platform in: openedx/edx-platform#34739 As a follow-on to that work, this commit removes the entirety of two blockstore-related plugins (tutor-contrib-blockstore-filesystem and tutor-contrib-blockstore-minio), as well as the blockstore configuration present in tutor-contrib-library-authoring-mfe.
ormsbee
added a commit
to openedx/openedx-tutor-plugins
that referenced
this pull request
May 17, 2024
Blockstore was completely removed from edx-platform in: openedx/edx-platform#34739 As a follow-on to that work, this commit removes the entirety of two blockstore-related plugins (tutor-contrib-blockstore-filesystem and tutor-contrib-blockstore-minio), as well most blockstore references present in tutor-contrib-library-authoring-mfe. The BLOCKSTORE_COLLECTION_UUID configuration value was left in place because it's expected by the Library Authoring MFE and currently required by the Django view that creates Libraries (even though the value is never used). We will remove those references in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Supporting Info
Implements openedx/public-engineering#238
Note: This also removes the
copy_library_from_v1_to_v2management command, which has been broken ever since we switched from Blockstore to Learning Core.Testing
Mostly, I'm counting on linting and unit tests to confirm that this is a clean removal.
Dave, can you confirm with this branch that you can still create and use Learning-Core-Backed Content Libraries locally (to the same extent that you were able to before)?
Merge Deadline
Before the Redwood cut, if possible.
Not a huge deal if it misses the cut, but it might muddy the waters to still have Blockstore references floating around in Redwood.