Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Blockstore from plugins + version bump to 0.3.0 #24

Merged
merged 3 commits into from
May 17, 2024

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented May 16, 2024

Blockstore was completely removed from edx-platform in openedx/edx-platform#34739

As a follow-on to that work, this PR removes the entirety of two blockstore-related plugins (tutor-contrib-blockstore-filesystem and tutor-contrib-blockstore-minio), as well as the blockstore configuration present in tutor-contrib-library-authoring-mfe.

The DEPR ticket: openedx/public-engineering#238

ormsbee added 2 commits May 16, 2024 17:10
Blockstore was completely removed from edx-platform in:
  openedx/edx-platform#34739

As a follow-on to that work, this commit removes the entirety of two
blockstore-related plugins (tutor-contrib-blockstore-filesystem and
tutor-contrib-blockstore-minio), as well as the blockstore configuration
present in tutor-contrib-library-authoring-mfe.
@ormsbee ormsbee marked this pull request as ready for review May 16, 2024 22:34
@ormsbee ormsbee requested a review from kdmccormick May 17, 2024 00:03
@ormsbee
Copy link
Contributor Author

ormsbee commented May 17, 2024

... oh right, edx-platform code for creating libraries still expects to pass a UUID... okay, time to shave this yak...

@ormsbee
Copy link
Contributor Author

ormsbee commented May 17, 2024

Actually, nvm, I'm just adding back the UUID even though it doesn't create anything. That way we can remove it later and not couple it to this removal/unblocking of provisioning with this plugin.

@ormsbee ormsbee requested a review from bradenmacdonald May 17, 2024 13:34
@ormsbee ormsbee changed the title Remove Blockstore from plugins Remove Blockstore from plugins + version bump to 0.3.0 May 17, 2024
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ormsbee ormsbee merged commit 4a145f9 into openedx:main May 17, 2024
2 checks passed
@ormsbee ormsbee deleted the remove-blockstore branch May 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants