-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: decoration of see all children link in wiki pages #33670
fix: decoration of see all children link in wiki pages #33670
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @ihor-romaniuk! There are some testing failures, could you take a look? Thanks! |
Hi @mariajgrimaldi! The Pull Request was updated and ready for review. |
Thanks @ihor-romaniuk! This looks better, but out of curiosity, why change it from markup to a style rule? |
Hi @mariajgrimaldi! Following up to see if you're still able to review this one? |
Nevermind, @mariajgrimaldi - just realized this still needs product review. |
This has product approval! |
I tested this locally and it's working as expected. I'll be merging this today, thanks! |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This pull request contains small recommendations for fixing the styling of the "See all children" link and replacing the decorative separator from the HTML markup with a style one.
Related Pull Requests
PR to the open-release/palm.master branch: #33668
PR to the open-release/quince.master branch: #33669
Screenshots/sandbox (optional):