Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoration of see all children link in wiki pages #33669

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Nov 7, 2023

Description

This pull request contains small recommendations for fixing the styling of the "See all children" link and replacing the decorative separator from the HTML markup with a style one.

Related Pull Requests

PR to the open-release/palm.master branch: #33668
PR to the master branch: #33670

Screenshots/sandbox (optional):

Before After
image image

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 7, 2023
@mariajgrimaldi
Copy link
Member

Hi there @ihor-romaniuk! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Thanks!

@cmltaWt0 cmltaWt0 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 6, 2024
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Mar 19, 2024
@mphilbrick211
Copy link

Hi @mariajgrimaldi! Are you able to merge this backport since the master is all set?

@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Mar 27, 2024
@mariajgrimaldi
Copy link
Member

@mphilbrick211: yes!

@mphilbrick211
Copy link

@mphilbrick211: yes!

Great, thanks, @mariajgrimaldi!

@mariajgrimaldi mariajgrimaldi merged commit 49cdbff into openedx:open-release/quince.master Apr 4, 2024
43 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/wiki-see-all-children-style-quince branch April 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants