Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: temporary setting to configure topic name for xblock events #32449

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: temporary setting to configure topic name for xblock events #32449

merged 1 commit into from
Jul 10, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Jun 14, 2023 •
edited
Loading

A temporary setting to configure topic name for xblock related openedx events. This will be removed once the decision in openedx/openedx-events#224 is approved and implemented.

Private-ref: BB-7555

@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2023
sameenfatima78
sameenfatima78 reviewed Jun 15, 2023
View reviewed changes
@sameenfatima78 sameenfatima78 mentioned this pull request Jun 15, 2023
Merged
9 tasks
@navinkarkera navinkarkera force-pushed the navin/temp-config-for-event-handlers branch from 513d987 to b2691f3 Compare June 16, 2023 10:43
@tecoholic
Copy link
Contributor

@navinkarkera 👍

  • I tested this: Checked that the code doesn't break
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@navinkarkera navinkarkera force-pushed the navin/temp-config-for-event-handlers branch 2 times, most recently from 7d9514c to efa6ba8 Compare June 23, 2023 07:08
@navinkarkera navinkarkera force-pushed the navin/temp-config-for-event-handlers branch 2 times, most recently from d6f57fe to 2630fbc Compare July 10, 2023 13:57
@navinkarkera navinkarkera force-pushed the navin/temp-config-for-event-handlers branch from 2630fbc to e55b5fb Compare July 10, 2023 14:04
@navinkarkera navinkarkera merged commit 051ecb4 into openedx:master Jul 10, 2023
@navinkarkera navinkarkera deleted the navin/temp-config-for-event-handlers branch July 10, 2023 14:24
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecoholic tecoholic tecoholic approved these changes

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navinkarkera @openedx-webhooks @tecoholic @edx-pipeline-bot @sameenfatima78