-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add temporary option to configure openedx event topic name #11
feat: add temporary option to configure openedx event topic name #11
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Should be okay to merge once failing builds go green. |
@sameenfatima78 Yes, the build issues are fixed in #10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I tested this: Didn't specifically test this.
- I read through the code
- I checked for accessibility issues
- Includes documentation
@navinkarkera CI seems to be failing due to codecov issues, can you kindly check if you can bump it's version to get the CI running? |
@tecoholic codecov has been removed from pypi. I have removed it and fixed CI in #10 . |
@navinkarkera I see. Thank you. |
@navinkarkera Can you rebase your PR so the failures are fixed? |
f20437c
to
8cef4eb
Compare
@sameenfatima78 Done. |
Hi @sameenfatima78! Friendly ping on this! |
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description: A temporary setting to configure topic name for skill-verified openedx event. This will be removed once the decision in openedx/openedx-events#224 is approved and implemented.
Private-ref
: BB-7555Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.