Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add temporary option to configure openedx event topic name #11

Merged

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Jun 14, 2023

Description: A temporary setting to configure topic name for skill-verified openedx event. This will be removed once the decision in openedx/openedx-events#224 is approved and implemented.

Private-ref: BB-7555

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@sameenfatima78
Copy link
Member

Should be okay to merge once failing builds go green. :shipit:

@navinkarkera
Copy link
Contributor Author

@sameenfatima78 Yes, the build issues are fixed in #10

Copy link

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera 👍

  • I tested this: Didn't specifically test this.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@tecoholic
Copy link

@navinkarkera CI seems to be failing due to codecov issues, can you kindly check if you can bump it's version to get the CI running?

@navinkarkera
Copy link
Contributor Author

@tecoholic codecov has been removed from pypi. I have removed it and fixed CI in #10 .

@tecoholic
Copy link

@navinkarkera I see. Thank you.

@sameenfatima78
Copy link
Member

@navinkarkera Can you rebase your PR so the failures are fixed?

@navinkarkera navinkarkera force-pushed the navin/temp-config-for-event-topic branch from f20437c to 8cef4eb Compare June 23, 2023 07:04
@navinkarkera
Copy link
Contributor Author

@sameenfatima78 Done.

@mphilbrick211
Copy link

Hi @sameenfatima78! Friendly ping on this!

@sameenfatima78 sameenfatima78 merged commit c45df8c into openedx:main Aug 9, 2023
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants