Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pii_check from xblock cookiecutter #423

Merged
merged 4 commits into from
Dec 13, 2023
Merged

fix: remove pii_check from xblock cookiecutter #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb0fd1d
fix: remove pii check from xblock cookiecutter
Dec 13, 2023
49e5ccc
fixup!: remove pii check from list
Dec 13, 2023
92f491c
fixup!: remove pii check from ci
Dec 13, 2023
2a34843
fixup!: changelog
Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ Change Log
This file loosely adheres to the structure of https://keepachangelog.com/,
but in reStructuredText instead of Markdown.

2023-12-13
**********

Changed
=======
- Remove pii_check from xblock cookiecutter

2023-12-06
**********

Expand Down
2 changes: 1 addition & 1 deletion cookiecutter-xblock/{{cookiecutter.repo_name}}/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
os: [ubuntu-20.04]
python-version: ['3.8']
toxenv: [quality, docs, pii_check, django32, django40]
toxenv: [quality, docs, django32, django40]

steps:
- uses: actions/checkout@v3
Expand Down
10 changes: 1 addition & 9 deletions cookiecutter-xblock/{{cookiecutter.repo_name}}/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py38-django{32,40}, quality, docs, pii_check
envlist = py38-django{32,40}, quality, docs
skipsdist = true

[doc8]
Expand Down Expand Up @@ -80,11 +80,3 @@ commands =
pydocstyle {{ cookiecutter.package_name }} manage.py
isort --check-only --diff test_utils {{ cookiecutter.package_name }} manage.py
make selfcheck

[testenv:pii_check]
setenv =
DJANGO_SETTINGS_MODULE = translation_settings
deps =
-r{toxinidir}/requirements/test.txt
commands =
code_annotations django_find_annotations --config_file .pii_annotations.yml --lint --report --coverage