fix: remove pii_check from xblock cookiecutter #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
approved these changes
Dec 13, 2023
womp, forgot to commit |
timmc-edx
approved these changes
Dec 13, 2023
This was referenced Dec 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes pii check from xblock cookiecutter. The check causes any new xblock to automatically start failing ci checks. Since there are only 2 xblocks that have ever needed pii_annotations files (because they talk to the database), it makes more sense just to remove the check. Tested that this check is not run when creating an xblock from this updated cookiecutter.
This duplicates some work from #412, but extracts it out into its own PR for ease of management and control.
Merge checklist:
Check off if complete or not applicable: