-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: complete enable-translations-new-repo.rst MFE and microservice sections #386
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a47d232
to
1241236
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left 2 little comments, nothing major.
Thank you so much for all this documentation!
1241236
to
8abe8d8
Compare
@brian-smith-tcril thanks for all the nit-picks and comments :). The document is much better now! Please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brian-smith-tcril! I don't have merge access to this repository. Would you mind merging it, or asking someone with access to do so? |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes
Combines the previously closed requests into a single PR:
Preview
Related links
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.