-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: complete the python repo documentation #382
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
bfe8318
to
0c408a0
Compare
7c78d45
to
12a832f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filling this out! Couple little suggestions but this LGTM!
Add a new entry under the ``python-translations`` section. For example for the XBlock located in | ||
``https://github.com/openedx/xblock-drag-and-drop-v2`` and has the XBlock Python | ||
module name ``drag_and_drop_v2`` it should have the following entry:: | ||
``https://github.com/openedx/xblock-drag-and-drop-v2`` it should have the following entry:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I've highlighted code that isn't part of the diff I can't do a suggestion, so here's my manual one:
Add a new entry under the ``python-translations`` section. For example, the XBlock located at
``https://github.com/openedx/xblock-drag-and-drop-v2`` should have the following entry::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@brian-smith-tcril this one is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Update the python repo section and address old TODO.
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.