-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add MFE and Microservices OEP-58 instructions #384
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
7b111b5
to
9b95557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I left a couple tiny suggestions but other than that this looks like it's good to go!
#. If you are creating a new repository, use the `cookiecutter-django-ida`_ | ||
template. | ||
|
||
**TODO:** How to enable translations infrastructure on a Django microservice | ||
#. For existing repos which don't have the ``make extract_translations`` or | ||
``make pull_translations`` command, they can be copied from the | ||
`edx-cookiecutters`_ Makefile in the ``cookiecutter-django-ida`` Makefile for Microservices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having these as numbered steps in a row makes this somewhat confusing. It currently renders as
- If you are creating a new repository
- For existing repos
It seems to me they should both be part of step 1.
#. If you are creating a new repository, use `frontend-template-application`_. | ||
|
||
**TODO:** How to enable translations infrastructure on a React repo | ||
#. For existing repos which don't have the ``make extract_translations`` or | ||
``make pull_translations`` command, they can be copied from the | ||
`frontend-template-application Makefile`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same note as the microservice one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are done. Good catch.
9b95557
to
503497c
Compare
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Fill in the missing steps for both microservices and micro-frontends.
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.