Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msp-operator has no rest url set #1076

Closed
kvaps opened this issue Jan 21, 2022 · 2 comments
Closed

msp-operator has no rest url set #1076

kvaps opened this issue Jan 21, 2022 · 2 comments
Assignees
@GlennBullingham
Labels
NEW New issue

Comments

@kvaps
Copy link

kvaps commented Jan 21, 2022

Describe the bug

msp-operator trying to GET http://$(rest_service_host):8081/ but this variable is not set:

https://github.com/openebs/mayastor-control-plane/blob/5f33aedc99dfca9f706cd23211d408539b7a3edf/deploy/msp-deployment.yaml#L49-L58

To Reproduce

Expected behavior
MayastorPool has created

Screenshots

Screenshot 2022-01-21 at 17 51 48

** OS info (please complete the following information):**

  • Distro: [e.g. NixOS]
  • Kernel version
  • MayaStor revision or container image

Additional context
Add any other context about the problem here.
@kvaps kvaps added the NEW New issue label Jan 21, 2022
@tiagolobocastro
Copy link
Contributor

Hi @kvaps, is the rest service NodePort created? AFAICT that environment variable should be set by the kubelet but it's not ideal as the node port must be created before the pod. We should probably change this to use the dns name instead (rest). As a quick WA you can try restarting the msp-operator.

@kvaps
Copy link
Author

kvaps commented Jan 21, 2022

I fixed this by replacing this by using hostname already

      - args:
        - -e http://rest:8081
        - --interval=30s

tiagolobocastro added a commit to openebs/mayastor-control-plane that referenced this issue Feb 1, 2022
@tiagolobocastro
fix: use dns name to reach rest
08ece34 
Using the host name creates a race as rest must start ahead.
Instead, simply use the dns name, which will be updated whenever rest is ready.
Resolves: openebs/mayastor#1076
tiagolobocastro added a commit to openebs/mayastor-control-plane that referenced this issue Feb 1, 2022
@tiagolobocastro
fix: use dns name to reach rest
cf5a317 
Using the host name creates a race as rest's node port must start ahead of its consumers.
Instead, simply use the dns name, which will be updated whenever rest is ready.
Resolves: openebs/mayastor#1076
Resolves: CAS-1288
@tiagolobocastro tiagolobocastro mentioned this issue Feb 1, 2022
Merged
tiagolobocastro added a commit to openebs/mayastor-control-plane that referenced this issue Jun 7, 2022
@tiagolobocastro
fix: use dns name to reach rest
222b7f3 
Using the host name creates a race as rest's node port must start ahead of its consumers.
Instead, simply use the dns name, which will be updated whenever rest is ready.
Resolves: openebs/mayastor#1076
Resolves: CAS-1288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GlennBullingham GlennBullingham

Labels
NEW New issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tiagolobocastro @kvaps @GlennBullingham