fix: use dns name to reach rest #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyoong
approved these changes
Feb 1, 2022
Using the host name creates a race as rest's node port must start ahead of its consumers. Instead, simply use the dns name, which will be updated whenever rest is ready. Resolves: openebs/mayastor#1076 Resolves: CAS-1288
tiagolobocastro
force-pushed
the
use_dns
branch
from
cf5a317 to
5acbb67
Compare
|
bors merge |
|
Build succeeded: |
tiagolobocastro
added a commit
that referenced
this pull request
Jun 7, 2022
212: fix: use dns name to reach rest r=tiagolobocastro a=tiagolobocastro chore: remove helm generation from precommit Co-authored-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: remove helm generation from precommit
fix: use dns name to reach rest
Using the host name creates a race as rest's node port must start ahead of its consumers.
Instead, simply use the dns name, which will be updated whenever rest is ready.
Resolves: openebs/mayastor#1076
Resolves: CAS-1288