Cherry-pick #438 and #439 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: It is not clear that `csi.node.topology.nodeSelector` is also impacting agent-ha-node daemonset Solution: Extend the `nodeSelector` documentation with a note that agent-ha-node node selector will be also updated with topology segments Signed-off-by: cmontemuino <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
- add README.md helm-docs template for crds subchart - add values to toggle install of all CRDs - coreutils to nix-shells - add value option to toggle installation of snapshot CRDs - refactor generate-readme.sh script to work with CRDs subchart Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
The CRDs in the helm chart have been moved to a subchart. They live in the subchart's 'templates' directory. They have templates which disables their installation if a CRD with the exact same name is already present in the kubernetes cluster. Thus, unless explicitly disabled, all templates are installed during helm upgrade. This functionality is no longer required. Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
niladrih
requested review from
tiagolobocastro,
sinhaashish,
Abhinandan-Purkait,
w3aman,
dsavitskiy and
rohan2794
dsavitskiy
approved these changes
Mar 21, 2024
w3aman
approved these changes
Mar 21, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the commits from the following PRs to release/2.6 branch: