docs(chart): update topology segments usage #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
approved these changes
Mar 18, 2024
tiagolobocastro
approved these changes
Mar 18, 2024
cmontemuino
force-pushed
the
improve-agent-ha-node-docs
branch
from
3667c64 to
46056b6
Compare
Problem: It is not clear that `csi.node.topology.nodeSelector` is also impacting agent-ha-node daemonset Solution: Extend the `nodeSelector` documentation with a note that agent-ha-node node selector will be also updated with topology segments Signed-off-by: cmontemuino <[email protected]>
cmontemuino
force-pushed
the
improve-agent-ha-node-docs
branch
from
46056b6 to
16b7626
Compare
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
450: Cherry-pick #438 and #439 r=niladrih a=niladrih This PR cherry-picks the commits from the following PRs to release/2.6 branch: - #438 - #439 Co-authored-by: cmontemuino <[email protected]> Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the
nodeSelectordocumentation with a note that agent-ha-node node selector will be also updated with topology segmentsMotivation and Context
It is not clear that
csi.node.topology.nodeSelectoris also impacting agent-ha-node daemonset.openebs/mayastor#1605
Regression
No
How Has This Been Tested?
Types of changes
It's documentation change only
Checklist: