feat(csi/node): add nvme-tcp init container #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds init container which waits on the nvme-tcp kernel module to be loaded. It's disabled by default. todo: use common init container image Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
avishnu,
Abhinandan-Purkait and
niladrih
niladrih
approved these changes
Feb 29, 2024
Abhinandan-Purkait
approved these changes
Feb 29, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
423: feat(csi/node): add nvme-tcp init container r=tiagolobocastro a=tiagolobocastro Adds init container which waits on the nvme-tcp kernel module to be loaded. It's disabled by default. todo: use common init container image <! Co-authored-by: Tiago Castro <[email protected]>
|
bors merge |
|
Build succeeded: |
avishnu
reviewed
Feb 29, 2024
| @@ -327,6 +327,12 @@ csi: | |||
| tolerations: [] | |||
| # -- Set PriorityClass, overrides global | |||
| priorityClassName: "" | |||
| initContainers: | |||
| enabled: false | |||
There was a problem hiding this comment.
Not enabled for mayastor chart itself, the umbrella should enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds init container which waits on the nvme-tcp kernel module to be loaded.
It's disabled by default.
todo: use common init container image
Description
Motivation and Context
This would allow an umbrella chart to enable the init container, preventing errors when starting the csi-node container.
Regression
How Has This Been Tested?
Types of changes
Checklist: