chore(bors): merge pull request #423

423: feat(csi/node): add nvme-tcp init container r=tiagolobocastro a=tiagolobocastro Adds init container which waits on the nvme-tcp kernel module to be loaded. It's disabled by default. todo: use common init container image <! Co-authored-by: Tiago Castro <[email protected]>
openebs · Feb 29, 2024 · e0d2bb2 · e0d2bb2
2 parents 2cabbf7 + b3e4952
commit e0d2bb2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/chart/templates/_helpers.tpl b/chart/templates/_helpers.tpl
@@ -60,6 +60,17 @@ Usage:
     {{- end }}
 {{- end -}}
 
+{{/*
+Renders the csi node init containers, if enabled
+Usage:
+{{ include "csi_node_init_containers" . }}
+*/}}
+{{- define "csi_node_init_containers" -}}
+    {{- if .Values.csi.node.initContainers.enabled }}
+    {{- include "render" (dict "value" .Values.csi.node.initContainers.containers "context" $) | nindent 8 }}
+    {{- end }}
+{{- end -}}
+
 {{/*
 Renders the base image pull secrets for all deployments, if any
 Usage:

diff --git a/chart/templates/mayastor/csi/csi-node-daemonset.yaml b/chart/templates/mayastor/csi/csi-node-daemonset.yaml
@@ -47,6 +47,8 @@ spec:
       {{- if $tolerations := include "tolerations" (dict "template" . "localTolerations" .Values.csi.node.tolerations) }}
       tolerations: {{ $tolerations }}
       {{- end }}
+      initContainers:
+        {{- include "csi_node_init_containers" . }}
       # NOTE: Each container must have mem/cpu limits defined in order to
       # belong to Guaranteed QoS class, hence can never get evicted in case of
       # pressure unless they exceed those limits. limits and requests must be

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -327,6 +327,12 @@ csi:
     tolerations: []
     # -- Set PriorityClass, overrides global
     priorityClassName: ""
+    initContainers:
+      enabled: false
+      containers:
+        - name: nvme-tcp-probe
+          image: busybox:latest
+          command: ['sh', '-c', 'trap "exit 1" TERM; until $(lsmod | grep nvme_tcp &>/dev/null); do [ -z "$WARNED" ] && echo "nvme_tcp module not loaded..."; WARNED=1; sleep 60; done;']
 
 io_engine:
   # -- Log level for the io-engine service