Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app node): update csi node with latests args to enable registration #415

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Abhinandan-Purkait
Copy link
Member

Changes in this PR

  1. Adds the dnsPolicy: ClusterFirstWithHostNet so that endpoints are discoverable by dns name.
  2. Adds the args to specify rest-api endpoint and enabled registration.

Why are the changes needed?

  1. These changes are needed because csi node now should register itself as an app node to the control-plane.
  2. This app node info would be used in snapshot creation to issue FIFREEZE and FITHAW to the filesystem for consistency if enabled.

Related Control Plane PR --> openebs/mayastor-control-plane#730

@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 81ede2b into develop Feb 13, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the csi_registration branch February 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants