Skip to content

Commit

Permalink
chore(bors): merge pull request #415
Browse files Browse the repository at this point in the history
415: feat(app node): update csi node with latests args to enable registration r=Abhinandan-Purkait a=Abhinandan-Purkait

### Changes in this PR

1. Adds the `dnsPolicy: ClusterFirstWithHostNet` so that endpoints are discoverable by dns name.
2. Adds the args to specify rest-api endpoint and enabled registration.

### Why are the changes needed?

1. These changes are needed because csi node now should register itself as an app node to the control-plane.
2. This app node info would be used in snapshot creation to issue FIFREEZE and FITHAW to the filesystem for consistency if enabled. 

Related Control Plane PR --> openebs/mayastor-control-plane#730

Co-authored-by: Abhinandan Purkait <[email protected]>
  • Loading branch information
mayastor-bors and Abhinandan-Purkait committed Feb 13, 2024
2 parents 1336bf6 + 2771272 commit 81ede2b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions chart/templates/mayastor/csi/csi-node-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ spec:
spec:
serviceAccount: {{ .Release.Name }}-service-account
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
imagePullSecrets:
{{- include "base_pull_secrets" . }}
{{- if $pcName := include "priority_class" (dict "template" . "localPriorityClass" .Values.csi.node.priorityClassName) }}
Expand Down Expand Up @@ -77,6 +78,8 @@ spec:
args:
- "--csi-socket={{ .Values.csi.node.pluginMounthPath }}/{{ .Values.csi.node.socketPath }}"
- "--node-name=$(MY_NODE_NAME)"
- "--rest-endpoint=http://{{ .Release.Name }}-api-rest:8081"
- "--enable-registration"
- "--grpc-endpoint=$(MY_POD_IP):10199"{{ if .Values.csi.node.nvme.io_timeout }}
- "--nvme-io-timeout={{ .Values.csi.node.nvme.io_timeout }}"
- "--nvme-core-io-timeout={{ .Values.csi.node.nvme.io_timeout }}"{{ else }}
Expand Down

0 comments on commit 81ede2b

Please sign in to comment.