Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /var/local paths should be under release name #343

Merged
merged 1 commit into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ $ helm install my-release openebs/mayastor
| etcd.​autoCompactionMode | AutoCompaction Since etcd keeps an exact history of its keyspace, this history should be periodically compacted to avoid performance degradation and eventual storage space exhaustion. Auto compaction mode. Valid values: "periodic", "revision". - 'periodic' for duration based retention, defaulting to hours if no time unit is provided (e.g. 5m). - 'revision' for revision number based retention. | `"revision"` |
| etcd.​autoCompactionRetention | Auto compaction retention length. 0 means disable auto compaction. | `100` |
| etcd.&ZeroWidthSpace;extraEnvVars[0] | Raise alarms when backend size exceeds the given quota. | <pre>{<br>"name":"ETCD_QUOTA_BACKEND_BYTES",<br>"value":"8589934592"<br>}</pre> |
| etcd.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;basePath | Host path where local etcd data is stored in. | `"/var/local/localpv-hostpath/{{ .Release.Name }}/etcd"` |
| etcd.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;basePath | Host path where local etcd data is stored in. | `"/var/local/{{ .Release.Name }}/localpv-hostpath/etcd"` |
| etcd.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;reclaimPolicy | ReclaimPolicy of etcd's localpv hostpath storage class. | `"Delete"` |
| etcd.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;volumeBindingMode | VolumeBindingMode of etcd's localpv hostpath storage class. | `"WaitForFirstConsumer"` |
| etcd.&ZeroWidthSpace;persistence.&ZeroWidthSpace;enabled | If true, use a Persistent Volume Claim. If false, use emptyDir. | `true` |
Expand Down Expand Up @@ -153,7 +153,7 @@ $ helm install my-release openebs/mayastor
| io_engine.&ZeroWidthSpace;tolerations | Set tolerations, overrides global | `[]` |
| localpv-provisioner.&ZeroWidthSpace;enabled | Enables the openebs dynamic-localpv provisioner. If disabled, modify etcd and loki-stack storage class accordingly. | `true` |
| loki-stack.&ZeroWidthSpace;enabled | Enable loki log collection for our components | `true` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;basePath | Host path where local etcd data is stored in. | `"/var/local/localpv-hostpath/{{ .Release.Name }}/loki"` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;basePath | Host path where local etcd data is stored in. | `"/var/local/{{ .Release.Name }}/localpv-hostpath/loki"` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;reclaimPolicy | ReclaimPolicy of loki's localpv hostpath storage class. | `"Delete"` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;volumeBindingMode | VolumeBindingMode of loki's localpv hostpath storage class. | `"WaitForFirstConsumer"` |
| loki-stack.&ZeroWidthSpace;loki.&ZeroWidthSpace;enabled | Enable loki installation as part of loki-stack | `true` |
Expand Down
8 changes: 4 additions & 4 deletions chart/templates/mayastor/io/io-engine-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ spec:
- "-g$(MY_POD_IP)"
- "-N$(MY_NODE_NAME)"
- "-Rhttps://{{ .Release.Name }}-agent-core:50051"
- "-y/var/local/io-engine/config.yaml"
- "-y/var/local/{{ .Release.Name }}/io-engine/config.yaml"
- "-l{{ include "cpuFlag" . }}"
- "-p={{ .Release.Name }}-etcd:{{ .Values.etcd.service.port }}"{{ if .Values.io_engine.target.nvmf.ptpl }}
- "--ptpl-dir=/var/local/io-engine/ptpl/"{{ end }}
- "--ptpl-dir=/var/local/{{ .Release.Name }}/io-engine/ptpl/"{{ end }}
- "--api-versions={{ .Values.io_engine.api }}"{{ if .Values.io_engine.target.nvmf.iface }}
- "-T={{ .Values.io_engine.target.nvmf.iface }}"{{ end }}{{ if .Values.io_engine.envcontext }}
- "--env-context=--{{ .Values.io_engine.envcontext }}"{{ end }}{{ if .Values.io_engine.reactorFreezeDetection.enabled }}
Expand All @@ -111,7 +111,7 @@ spec:
- name: dshm
mountPath: /dev/shm
- name: configlocation
mountPath: /var/local/io-engine/
mountPath: /var/local/{{ .Release.Name }}/io-engine/
- name: hugepage
mountPath: /dev/hugepages
resources:
Expand Down Expand Up @@ -145,5 +145,5 @@ spec:
medium: HugePages
- name: configlocation
hostPath:
path: /var/local/io-engine/
path: /var/local/{{ .Release.Name }}/io-engine/
type: DirectoryOrCreate
4 changes: 2 additions & 2 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ etcd:
# Name of etcd's localpv hostpath storage class.
name: "mayastor-etcd-localpv"
# -- Host path where local etcd data is stored in.
basePath: "/var/local/localpv-hostpath/{{ .Release.Name }}/etcd"
basePath: "/var/local/{{ .Release.Name }}/localpv-hostpath/etcd"
Abhinandan-Purkait marked this conversation as resolved.
Show resolved Hide resolved
# -- ReclaimPolicy of etcd's localpv hostpath storage class.
reclaimPolicy: Delete
# -- VolumeBindingMode of etcd's localpv hostpath storage class.
Expand Down Expand Up @@ -486,7 +486,7 @@ loki-stack:
# Name of loki's localpv hostpath storage class.
name: "mayastor-loki-localpv"
# -- Host path where local etcd data is stored in.
basePath: "/var/local/localpv-hostpath/{{ .Release.Name }}/loki"
basePath: "/var/local/{{ .Release.Name }}/localpv-hostpath/loki"
# -- ReclaimPolicy of loki's localpv hostpath storage class.
reclaimPolicy: Delete
# -- VolumeBindingMode of loki's localpv hostpath storage class.
Expand Down