Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /var/local paths should be under release name #343

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

Abhinandan-Purkait
Copy link
Member

Description

Currently we use /var/local/io-engine and /var/local/local-pv-hostpath/{{ .Release.Name }}
This is a bit too spread we should bundle it all within a common /var/local/{{ .Release.Name }} example:-
/var/local/{{ .Release.Name }}/{io-engine, localpv-hostpath}

This PR changes the helm chart to include this.

Motivation and Context

Regression

No

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

chart/values.yaml Outdated Show resolved Hide resolved
chart/values.yaml Show resolved Hide resolved
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“What's in a {{ .Release.Name }}? That which we call a rose by any other name would smell just as sweet.” - William Shakespeare

@Abhinandan-Purkait
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 22, 2023
343: fix: /var/local paths should be under release name r=Abhinandan-Purkait a=Abhinandan-Purkait

<!

Co-authored-by: Abhinandan Purkait <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 22, 2023

This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0cd3e88 into develop Sep 22, 2023
4 checks passed
@bors bors bot deleted the localpath branch September 22, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants