-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: /var/local paths should be under release name #343
Conversation
4503c20
to
b74336b
Compare
Signed-off-by: Abhinandan Purkait <[email protected]>
b74336b
to
2c79063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“What's in a {{ .Release.Name }}? That which we call a rose by any other name would smell just as sweet.” - William Shakespeare
bors merge |
343: fix: /var/local paths should be under release name r=Abhinandan-Purkait a=Abhinandan-Purkait <! Co-authored-by: Abhinandan Purkait <[email protected]>
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Description
Currently we use
/var/local/io-engine
and/var/local/local-pv-hostpath/{{ .Release.Name }}
This is a bit too spread we should bundle it all within a common
/var/local/{{ .Release.Name }}
example:-/var/local/{{ .Release.Name }}/{io-engine, localpv-hostpath}
This PR changes the helm chart to include this.
Motivation and Context
Regression
NoHow Has This Been Tested?
Types of changes
Checklist: