-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better formatting of analysis page #151
Conversation
mccalluc
commented
Nov 8, 2024
- Fix Better formatting of demo help on analysis page #150
- Fix Only show warning about fake data in graph once, not for every column #138
- Builds on Move reactive values up to top level #142: Merge that first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and the UI has the changes described. I noticed that output
and session
aren't used in analysis_server(), can they be removed?
Please resolve the merge conflicts. |
not really: These aren't functions I call, instead, it's an interface defined by Shiny that we need to satisfy. If I delete them in
I think since it's missing expected positional parameters, it's grabbing kwargs, and things get confused. Will resolve conflicts and ask for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved