Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting of analysis page #151

Merged
merged 16 commits into from
Nov 13, 2024
Merged

Conversation

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and the UI has the changes described. I noticed that output and session aren't used in analysis_server(), can they be removed?

Base automatically changed from 129-move-column-controls-to-top to main November 12, 2024 02:36
@pdurbin
Copy link
Collaborator

pdurbin commented Nov 12, 2024

Please resolve the merge conflicts.

@mccalluc
Copy link
Contributor Author

@ekraffmiller

I noticed that output and session aren't used in analysis_server(), can they be removed?

not really: These aren't functions I call, instead, it's an interface defined by Shiny that we need to satisfy. If I delete them in dataset_panel I get this error:

TypeError: dataset_server() got multiple values for argument 'csv_path'

I think since it's missing expected positional parameters, it's grabbing kwargs, and things get confused.

Will resolve conflicts and ask for re-review.

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved

@mccalluc mccalluc merged commit 40e0b9c into main Nov 13, 2024
2 checks passed
@mccalluc mccalluc deleted the 150-138-analysis-formatting branch November 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
3 participants