Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reactive values up to top level #142

Merged
merged 12 commits into from
Nov 12, 2024
Merged

Move reactive values up to top level #142

merged 12 commits into from
Nov 12, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 5, 2024 •
edited
Loading

@ekraffmiller ekraffmiller self-assigned this Nov 7, 2024
ekraffmiller
ekraffmiller reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, and when columns are added in the Analysis Tab, the inputs are reset, see example:

Screen.Recording.2024-11-07.at.12.45.32.PM.mov

ekraffmiller
ekraffmiller requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue when checking a column on the Analysis page, see comments

@ekraffmiller ekraffmiller removed their assignment Nov 7, 2024
This was referenced Nov 7, 2024
Closed
Closed
Merged
ekraffmiller
ekraffmiller approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, values are retained when new columns are checked.

@mccalluc mccalluc merged commit 42e3801 into main Nov 12, 2024
2 checks passed
@mccalluc mccalluc deleted the 129-move-column-controls-to-top branch November 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Lower"/"Upper" instead of "Min"/"Max" Reactive values for analysis details should live at the top level
2 participants
@mccalluc @ekraffmiller