Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo tooltips on the analysis panel #135

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Demo tooltips on the analysis panel #135

merged 2 commits into from
Nov 7, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 4, 2024 •
edited
Loading

I think something like this would be good... but maybe this is too much text for this format?

ekraffmiller
ekraffmiller previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I like all the information about how to use the demo data. Maybe in a future iteration, it could be made more prominent, maybe as extra text on the page, rather than in a tooltip. But I thinks it works well for now.

@mccalluc mccalluc mentioned this pull request Nov 7, 2024
Open
@mccalluc mccalluc merged commit 87b6f8e into main Nov 7, 2024
2 checks passed
@mccalluc mccalluc deleted the 127-define-analysis-tooltips branch November 7, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo tooltips on Define Analysis
2 participants
@mccalluc @ekraffmiller